Add missing 'version' param to get WMS legends (ref #11)#12
Open
marcantoinedupre wants to merge 1 commit into
Open
Add missing 'version' param to get WMS legends (ref #11)#12marcantoinedupre wants to merge 1 commit into
marcantoinedupre wants to merge 1 commit into
Conversation
077dc04 to
6040838
Compare
Author
|
I have updated my fix. The version value is at |
Author
|
Any news on this? @ignaciofagian @dandormont |
Contributor
|
Sorry I'm not the maintainer here. I just happen to have contributed some minor fixes. I'm also not all that familiar with WMS to be perfectly honest 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a one-line fix to add the missing
versionparam to WMSGetLegendGraphicrequests (solves #11). The value passed is the one from Leaflet (default or overridden value).According to the spec:
OpenGIS Web Map Service (WMS) Implementation Specification, p. 11.
And some map servers enforce this, as the WMSServer component of an Arcgis server.
It would be awesome if you could merge it and release! 🙏