Repository navigation
Conversation
Avoid advancing generated IDs or invoking unused throwing factories for supplied non-object and strict values. Preserve undefined defaults, object merging and underlying coercion. AI assistance: OpenAI Codex.
FanWu-ai
marked this pull request as ready for review
October 11, 2026 22:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented
defaulted(number(), () => i++)ID generator advances even when an ID was supplied and its fallback is discarded. Creating{id: 42}followed by{}assigns the generated ID 1 rather than 0. A valid supplied value also throws when its unused default factory throws.Return supplied values before evaluating fallbacks when strict mode is enabled or the input is not a plain object. Undefined input still evaluates once. Non-strict plain objects still evaluate the fallback because its properties may need merging. The wrapped struct's own coercer still executes.
Validation on Node 24.19.0 and 22.19.0:
The reused dependencies retain an existing
expect29.7 compatibility resolution for wildcard@types/expect; no dependency change is made here, and a fresh unpinned CI install may differ. Other runtimes and hosted checks are not claimed passed. Prepared and tested with AI assistance (OpenAI Codex); no human review is claimed.