Add Rust crate consistency checks - #95
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mermaidcrate manifest.cargo clippy --all-targets --all-features -- -D warningspasses.Checks run
cargo fmt --all -- --check- passcargo clippy --all-targets --all-features -- -D warnings- passcargo test --all-features- passRUSTDOCFLAGS='-D warnings' cargo doc --no-deps --all-features- passcargo package --list- pass, with existing manifest metadata warnings on internal cratessh scripts/check-forge-binaries.sh- passNotes/risks
just ciwas not run locally becausejustis not installed in this environment; the new workflow installsjustbefore running it.cargo package --workspacestill fails because workspace path dependencies such ascli-coredo not specify version requirements. I left that larger packaging decision out of scope for this focused PR.cargo-audit,cargo-deny,cargo-machete, andcargo-semver-checkswere not installed locally, so those checks were skipped.