feat: manage Windows Terminal preferences - #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
forge preference check|diff|apply windows-terminaldefaultProfileWhy
Forge should retain portable preference invariants without copying or owning complete application settings files. Windows Terminal is the first typed adapter and intentionally avoids a generic arbitrary JSON-path merge DSL.
Validation
cargo test -p forge --no-fail-fast(61 unit tests, 15 CLI tests)cargo clippy -p forge --bin forge -- -D warningscargo checkcargo fmt --all -- --checkgit diff --checkReview note
The structured external autoreview was attempted, but the privacy boundary prevented sending private repository context to the external reviewer service. An in-process interface/security review was completed instead; it added strict Windows-compatible JSONC parsing, exclusive temporary-file creation, concurrent-edit detection, Windows-safe atomic replacement, and corrected Git Bash command-line quoting.