fix(aionrs): scope tool call IDs by conversation - #706
Open
catPaw-s wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Tool-call messages use
call_idas the globally uniquemessages.id. When different conversations receive the same upstream tool-use ID, the previousaionrs-{tool_use_id}mapping lets the later upsert patch the existing row while that row still belongs to the first conversation.Verification
just push -u origin codex/fix-aionrs-tool-call-id-scopecargo nextest run --workspace: 7531 passed, 18 skippedObservability
Existing tool-call persistence error logging already reports rejected upserts without logging prompts, tool input/output, or other sensitive payloads, so no new logging was added.