Skip to content

fix: preserve stopped terminal state across restarts - #30

Open
hyudryu wants to merge 2 commits into
mainfrom
fix/post-merge-session-persistence
Open

hyudryu wants to merge 2 commits into
mainfrom
fix/post-merge-session-persistence

Conversation

@hyudryu

@hyudryu hyudryu commented Sep 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • tolerate direct PTY exits racing renderer reattachment
  • persist stopped panes and durably checkpoint their final output before exit acknowledgement
  • clean exact Windows host generations without respawning shells, while retaining bounded mobile stopped frames
  • preserve fallback scrollback before generation-bound snapshots when workspace storage is constrained

Validation

  • node --test test/session-reattach.test.cjs test/mobile-sidebar-performance.test.cjs test/windows-pty-persistence.test.cjs test/workspace.test.js (64 passed)
  • npm test -- --test-reporter=dot (430 passed)
  • npm run build:web (passed; existing chunk-size warning only)
  • node --check on touched JavaScript and CommonJS files
  • git diff --check

Follow-up for the three post-merge Codex findings on #29.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-03T03:28:46.062554Z d627f75 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1a6ccd0973

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/main.js Outdated
Comment thread src/main.js Outdated
Comment thread src/main.js Outdated
Comment thread src/main.js Outdated
Comment thread src/main.js Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant