Update LiveSplit.PkmnTCG_try1.asl#1
Draft
Junzyo wants to merge 1 commit into
Draft
Conversation
First attempt at committing changes to my first fork. Nervous. Intent is to enable functionality for the club members you need to defeat in the Any% category. Added parent groupings to keep the Any% opponents together -- unless I made mistakes -- and (unnecessary) tooltips. Such a GitHub novice that I don't know if I should select "commit directly to the master branch" or "create a new branch for this commit and start a pull request". It just means the master branch for my fork, right? I'll play it safe and do the latter, maybe I'll learn something from the experience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First attempt at committing changes to my first fork. Nervous. Intent is to enable functionality for the club members you need to defeat in the Any% category. Added parent groupings to keep the Any% opponents together -- unless I made mistakes -- and also added (unnecessary?) tooltips. The tooltips were mostly to see if I could implement them while I learned other things. Maybe should have renamed a few things from the version I was working on before trying something on GitHub -- especially the tooltips, but maybe the descriptions for the parents too(?). Could've easily used fewer words and/or characters.
Such a GitHub novice that I don't know if I should select "commit directly to the master branch" or "create a new branch for this commit and start a pull request". It just means the master branch for my fork, right? I'll play it safe and do the latter, maybe I'll learn something from the experience. I'll try and keep as much as a draft as I can until I feel comfortable while I keep learning things.