Skip to content

fix(runtime): adapt CallConfig dump args rename#2020

Open
Little-oil wants to merge 1 commit into
hw-native-sys:mainfrom
Little-oil:codex/adapt-latest-simpler-callconfig-main
Open

fix(runtime): adapt CallConfig dump args rename#2020
Little-oil wants to merge 1 commit into
hw-native-sys:mainfrom
Little-oil:codex/adapt-latest-simpler-callconfig-main

Conversation

@Little-oil

Copy link
Copy Markdown
Contributor

Summary

  • map PyPTO's backward-compatible RunConfig.enable_dump_tensor to simpler's renamed CallConfig.enable_dump_args
  • update L2, device, and L3 dispatch paths plus related tests and codegen comments

Validation

  • python -m pytest -q tests/ut/runtime/test_worker_reuse.py
  • targeted CallConfig mapping check with latest simpler
  • ruff check

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: aa849c93-03b3-4d18-9f0e-7bba6e57931c

📥 Commits

Reviewing files that changed from the base of the PR and between 725e841 and f9f9232.

📒 Files selected for processing (7)
  • python/pypto/runtime/device_runner.py
  • python/pypto/runtime/distributed_runner.py
  • python/pypto/runtime/runner.py
  • src/codegen/orchestration/orchestration_codegen.cpp
  • tests/ut/ir/test_compiled_program.py
  • tests/ut/runtime/test_distributed_worker.py
  • tests/ut/runtime/test_run_config.py

📝 Walkthrough

Walkthrough

The change maps PyPTO’s public enable_dump_tensor setting to the runtime CallConfig.enable_dump_args field across execution paths, updates orchestration documentation, and adjusts unit-test doubles and assertions accordingly.

Changes

Dump field mapping

Layer / File(s) Summary
Runtime CallConfig wiring
python/pypto/runtime/*runner.py
Device, distributed, and standard runners now assign tensor-dump settings to enable_dump_args while preserving the public enable_dump_tensor API.
Validation and codegen alignment
src/codegen/orchestration/orchestration_codegen.cpp, tests/ut/ir/test_compiled_program.py, tests/ut/runtime/test_distributed_worker.py, tests/ut/runtime/test_run_config.py
Orchestration comments and unit-test fixtures, mocks, and assertions now reference enable_dump_args.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

I’m a bunny with a config bright,
Dump args hop into place just right.
Old names stay for paths well-worn,
New fields greet the debugging morn.
Tests twitch noses: all is sound!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: renaming and remapping CallConfig dump args in runtime code.
Description check ✅ Passed The description matches the changeset and summarizes the runtime mapping update plus related tests and comments.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates references to enable_dump_tensor in CallConfig to enable_dump_args across the Python runtime runners, C++ codegen comments, and unit tests, while maintaining the public enable_dump_tensor interface for backward compatibility. I have no feedback to provide as there are no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant