Skip to content

ci: remove obsolete PyPTO PTO-ISA pytest option#965

Draft
mouliangyu wants to merge 1 commit into
hw-native-sys:mainfrom
mouliangyu:fix/pypto-removed-pto-isa-option
Draft

ci: remove obsolete PyPTO PTO-ISA pytest option#965
mouliangyu wants to merge 1 commit into
hw-native-sys:mainfrom
mouliangyu:fix/pypto-removed-pto-isa-option

Conversation

@mouliangyu

Copy link
Copy Markdown
Collaborator

Summary

  • stop passing the removed --pto-isa-commit option to PyPTO simulator pytest runs
  • keep the existing explicit PTO-ISA checkout and PTO_ISA_ROOT wiring unchanged

Background

PyPTO commit 86549ddd removed the --pto-isa-commit pytest option. Because this workflow checks out PyPTO main, pytest now exits during argument parsing before collecting any simulator test:

error: unrecognized arguments: --pto-isa-commit=...

This caused the vpto-sim-validation job to fail independently of the PTOAS change under test.

Validation

  • git diff --check
  • parsed .github/workflows/ci_sim.yml with PyYAML
  • ran PyPTO's hello-world simulator test with the remaining workflow arguments and --collect-only (1 test collected)

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant