Repository navigation
Intent: reject malformed input without partial content - #135
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Malformed intent nodes, list items and table cells could disappear or become empty content while reporting success. Closes #127.
Solution
Reject malformed values where the existing assembly walk consumes them. Errors identify the input path and expected shape; realize returns its existing failed report and low-level assemble rejects.
Diff
+100 / −19 across three files.
Testing & verification
Reviewed revision:
de9f02a60a098e2404dfb6b94352569b004ba730· Environment: Node 24.18.0, macOS arm64.npm run typecheck: passed.git diff --check: passed.npx vitest run dev/test/intent.test.ts dev/test/cli.test.ts: 69 passed.Not verified: destination-site rendering or manual editor acceptance. These are input-construction checks against the pinned headless runtime.
Risk / rollout
Malformed input now fails instead of returning partial content. The attribute envelope remains open; no preflight schema or coercion is introduced.
Detection: input-path regression tests and CLI sentinel checks. Rollback: revert this PR; doing so restores the previous partial-output behavior.