Repository navigation
Add : void return type to test setUp() methods - #35
Merged
Merged
Conversation
Required by PHPUnit 8+ and PHPUnit polyfills' LSP check. Nightly currently fails on this module with a setUp() signature mismatch. PHP 7.1+ compatible. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mikelittle
requested review from
ferschubert-hm,
filter182,
jerico,
vladislavhmn and
wisyhambolu
May 22, 2026 15:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPUnit 8+ and PHPUnitPolyfills declare
TestCase::setUp(): void; subclass overrides without the matching return type fatal under LSP.Currently breaks nightly cross-version tests in humanmade/product-dev with:
```
Fatal error: Declaration of Altis\Security\Browser\Test_Content_Security_Policies::setUp()
must be compatible with Yoast\PHPUnitPolyfills\TestCases\TestCase::setUp(): void
```
Touches
tests/class-test-content-security-policies.phpandtests/class-test-rest-allow-origins.php. PHP 7.1+ compatible (matches module floor).