Skip to content

Use default version for hash generation if not set #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmccue merged 4 commits into from
Feb 24, 2026
Merged

Use default version for hash generation if not set #33

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7dae11
Use default version for hash generation if not set
mattheu Feb 16, 2026
be3ff69
Update version determination logic for assets
mattheu Feb 18, 2026
13dca05
Rename variable 'ver' to 'version' for clarity
mattheu Feb 18, 2026
5dbf329
Update inc/namespace.php
mattheu Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion inc/namespace.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,16 @@ function generate_hash_for_asset( WP_Dependencies $dependencies, string $handle
);
}

// Determine version with default version following same logic as core WP_Scripts and WP_Styles.
if ( null === $asset->ver ) {
$version = '';
} else {
$version = $asset->ver ?: $dependencies->default_version;
}

// Generate the hash.
$hash = generate_hash_for_path( $actual_path, $asset->ver );
$hash = generate_hash_for_path( $actual_path, $version );

if ( empty( $hash ) ) {
// Couldn't generate a hash.
return new WP_Error(
Expand Down