Skip to content

Fix Receive by fulfillment setting compatibility - #742

Closed
dt2patel wants to merge 1 commit into
mainfrom
codex/receiving-fulfillment-setting
Closed

dt2patel wants to merge 1 commit into
mainfrom
codex/receiving-fulfillment-setting

Conversation

@dt2patel

@dt2patel dt2patel commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Stores with Receive by fulfillment enabled as true currently see the toggle off and receive quantity calculations based on ordered rather than fulfilled quantity. Toggling it on writes Y, which is incompatible with the OMS true check.

This restores the existing true/false contract for RECEIVE_BY_FULFILL: the getter accepts boolean true after loading and the string true immediately after saving, and the toggle saves true/false. Other settings retain their existing Y/N behavior. No backend or production data changes.

Closes #741.

Validation:

  • Seven new store regression tests cover existing true/false values, immediate save and reload, missing settings, and unchanged force-scan Y/N behavior.
  • The two enabled-setting regression cases fail against unfixed main and pass with the fix.
  • vitest run src/store/productStore.settings.spec.ts src/composables/useReceiveFlowState.spec.ts src/views/transferOrderDetailReceiveWorkflow.spec.ts: 13 passed.
  • vite build: passed using the isolated worktree and example environment configuration.
  • git diff --check: passed.

Read-only Tathya evidence established Gorjana's saved setting is true. Unit tests use API fixtures; an authenticated browser check against Gorjana has not been performed. This PR does not migrate any stores that already have Y/N saved for this setting.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@ravilodhi

Copy link
Copy Markdown
Contributor

Handled in this PR - #744

Closing this PR.

@ravilodhi ravilodhi closed this Oct 2, 2026
@ymaheshwari1
ymaheshwari1 deleted the codex/receiving-fulfillment-setting branch October 2, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Receive by fulfillment misreads existing true setting and saves incompatible values

2 participants