Repository navigation
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
|
Handled in this PR - #744 Closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stores with Receive by fulfillment enabled as
truecurrently see the toggle off and receive quantity calculations based on ordered rather than fulfilled quantity. Toggling it on writesY, which is incompatible with the OMStruecheck.This restores the existing
true/falsecontract forRECEIVE_BY_FULFILL: the getter accepts booleantrueafter loading and the stringtrueimmediately after saving, and the toggle savestrue/false. Other settings retain their existingY/Nbehavior. No backend or production data changes.Closes #741.
Validation:
vitest run src/store/productStore.settings.spec.ts src/composables/useReceiveFlowState.spec.ts src/views/transferOrderDetailReceiveWorkflow.spec.ts: 13 passed.vite build: passed using the isolated worktree and example environment configuration.git diff --check: passed.Read-only Tathya evidence established Gorjana's saved setting is
true. Unit tests use API fixtures; an authenticated browser check against Gorjana has not been performed. This PR does not migrate any stores that already have Y/N saved for this setting.