Repository navigation
RET-5980 - #3422
Open
LahiruOshara wants to merge 17 commits into
Open
RET-5980#3422LahiruOshara wants to merge 17 commits into
LahiruOshara wants to merge 17 commits into
Conversation
|
Release version for latest commit is: RET-5980-2c27ee8 |
|
Release version for latest commit is: RET-5980-d46d823 |
|
Release version for latest commit is: RET-5980-248527a |
|
Release version for latest commit is: RET-5980-103a140 |
|
Release version for latest commit is: RET-5980-04af301 |
|
Release version for latest commit is: RET-5980-fdc888e |
|
Release version for latest commit is: RET-5980-6f6deae |
hsjhita
previously approved these changes
Sep 8, 2026
btensay
previously approved these changes
Sep 8, 2026
|
Release version for latest commit is: RET-5980-d5b5092 |
Contributor
Plan Result (aat)
|
Contributor
Plan Result (prod)
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira link
https://hmcts.atlassian.net/browse/RET-5980
Change description
Problem
Closing, replying to or updating a referral completed the Work Allocation tasks for
every open referral on the case. Reported from Production: closing referral 5
completed a caseworker's assigned task for referral 32.
The completion DMN only receives the CCD event id, so it cannot tell one referral
from another — it matches on case id + task type and completes everything it finds.
Fix
et-ccd-callbacks now completes the specific tasks itself:
POST /task(as the acting user — needs only Read) for the case'sreferral tasks.
additional_properties.referralNumbermatches the referralthat was actioned.
DELETE /task/{id}(service-to-service, reasoncompleted).The referral number is stamped onto each task by the configuration DMN — see the
paired et-wa-task-configuration PR, which also removes the blanket completion
rules. Task types per event mirror the DMN exactly, so behaviour is unchanged apart
from the cross-referral over-reach.
Changes
WaTaskApiClient+ request/response DTOsReferralTaskCompletionServiceWA_TASK_MANAGEMENT_API_URLconfig (app, charts, integration + apiTest)Testing
ReferralTaskCompletionServiceTest(8 tests) plus the three controller tests.Screen.Recording.2026-09-03.at.10.04.51.mov
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist