You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the simsopt repository only includes B_regularized in src/simsopt/field/selffield.py (and also in the coil class in coil.py). I added B_0, B_kappa and B_b.
There are 3 main additions (the rest is due to autopep and ruff):
in selffield.py : the direct implementation of the different B field computation (from line 174)
in coil.py: the three B field contributions are added in the class "RectangularRegulaziedCoil" (from line 266)
in test_selffieldforces.py : added some assert to ensure that the tests pass for the new B fields (line 566 to 589)
This code has already been used by at IPP (Garching, Germany) for a paper about Ic-optimisation in the winding pack (currently in writing).
I mischanged the function coils_to_vtk in coil.py, which was not intentional. I thus restored the original function as it was. From all the unittests this was the only error I saw
❌ Patch coverage is 99.29577% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.47%. Comparing base (51b2245) to head (f4dd62e). ⚠️ Report is 4 commits behind head on master.
@mbkumar The pointed linting errors are not in the files I changed (I only changed src/simsopt/coil.py and selffield.py), so I am pretty confused. Do you want me to fix them anyway ?
The reason will be displayed to describe this comment to others. Learn more.
I may misunderstand, this can already be computed by building a BiotSavart object, not?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented the full B field for self-field in the winding pack according to the paper of Dr. Landreman
(https://iopscience.iop.org/article/10.1088/1741-4326/adb04e/meta).
Currently, the simsopt repository only includes B_regularized in src/simsopt/field/selffield.py (and also in the coil class in coil.py). I added B_0, B_kappa and B_b.
There are 3 main additions (the rest is due to autopep and ruff):
in selffield.py : the direct implementation of the different B field computation (from line 174)
in coil.py: the three B field contributions are added in the class "RectangularRegulaziedCoil" (from line 266)
in test_selffieldforces.py : added some assert to ensure that the tests pass for the new B fields (line 566 to 589)
This code has already been used by at IPP (Garching, Germany) for a paper about Ic-optimisation in the winding pack (currently in writing).
I remain available for any question.
Kind regards