Repository navigation
test(ci): measure the studio viewport gate at #5151 three times, do not merge - #5155
Closed
miguel-heygen wants to merge 8 commits into
Closed
miguel-heygen wants to merge 8 commits into
miguel-heygen wants to merge 8 commits into
Conversation
dorny/paths-filter with token "" diffs pull_request.base.sha..merge with two dots; base.sha goes stale as main moves, so a PR behind main counted main's newer commits as its own and ran unrelated gates. Pass the merge commit's first parent as base on pull requests.
…mmit echo "sha=$(git rev-parse HEAD^1)" exited 0 when rev-parse failed, and on a non-merge checkout HEAD^1 would be the PR's previous commit, silently skipping gates. Verify HEAD^2 exists and assign the SHA so a failure stops the step.
…zoom previews keep half #5109 widened the render window to half a viewport so zoom-out previews have clips to show; every scroll step then mounted it and the viewport gate's interaction p95 went over budget. Widen only while a zoom preview is live, telling listeners before its first frame and widening the preview's drawn range once mounted.
…widen before frame one The render window followed isTimelineZoomPreviewing, still true during the landing layout's flushSync, so each landing rendered the wide window and then a second time narrow. It now follows its own flag, cleared before that layout. An eased zoom starts its preview at the current scale before its first frame, so the wider window is mounted when that frame is judged.
… gate counts blank zoom-out frames When a zoom landed, the timeline laid it out against the scroll snapshot from before the zoom; the real scroll was published a frame or more later, so a zoom-out far into a project showed no clips or ruler ticks meanwhile. The zoom-anchor layout effect now publishes the scroll it sets, before paint. The viewport gate zooms out by Ctrl+wheel and by pinch from mid-project and fails on any frame with no ruler tick in view.
Collaborator
Author
|
Measured: 3/3 first-attempt pass in both arms, 0 blank zoom-out frames. Recorded in #5151. |
Edit accuracy: accurate 2059 (base branch 2059), smooth 1605 of thoseThe gate passes. Quarantined, measured but not gated (0) Unstable (1)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway measurement: #5151's head with the Studio timeline viewport gate run three times in parallel. Closed and deleted once the numbers are recorded.