Repository navigation
fix(studio-server): prevent inline-image preview tracking OOM - #5100
Merged
Merged
Conversation
Edit accuracy: accurate 2055 (base branch 2055), smooth 1656 of thoseThe gate passes. Quarantined, measured but not gated (0) Unstable (1)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prevents the Desktop launch crash caused by tracking an inlined background image as a filesystem path.
Why
An entity-quoted CSS URL such as
url("data:image/png;base64,...")bypasses the scheme check. Every slash in the base64 then triggers filesystem and ancestor tracking, consuming memory until the app crashes.Related work
Fixes #5097. Delivery requires an OSS release followed by the Desktop package update.
How
Use the existing HTML parser to decode actual attributes, while keeping stylesheet and script text literal. Reject non-file URLs and bound decoded and resolved filesystem paths before walking them. Local assets, query strings, percent escapes, symlinks and nested templates keep their preview tracking.
Test plan