Repository navigation
fix(studio): a move keeps an authored xPercent centring set in the saved file - #4867
Closed
miguel-heygen wants to merge 3 commits into
Closed
miguel-heygen wants to merge 3 commits into
miguel-heygen wants to merge 3 commits into
Conversation
miguel-heygen
force-pushed
the
fix/studio-keep-xpercent-centring-set
branch
from
October 1, 2026 16:47
abda1c4 to
da5b4c3
Compare
Contributor
Edit accuracy: 875 passing here, 841 on the base branchThe gate fails: 34 newly passing case(s) are not banked in baseline.json. Newly passing (34)
Not banked (commit the artifact's baseline.json) (34)
Quarantined, measured but not gated (7)
|
miguel-heygen
force-pushed
the
fix/studio-keep-xpercent-centring-set
branch
from
October 1, 2026 19:17
fda88fe to
a65719d
Compare
Collaborator
Author
|
Closing: this change now ships inside #4869, the lane's one PR. The captures and gate numbers here carry over there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moving, nudging or resizing an element centred with
gsap.set({ xPercent: -50, yPercent: -50 })that also has an x/y tween now keeps the centring set in the saved file. Before, the save deleted it and the element landed half its size down and to the right.Why
Before a GSAP move commits, Studio removes duplicate position writes for the element. It counted every write in the
positiongroup as a duplicate, and that group holdsx,y,xPercentandyPercent. A centring set and an x/y tween were treated as two conflicting writes and the set was deleted. The drag preview looked right, so only the drop was wrong, and reload and render then agreed with the wrong file.Related work
Refs #4774 (closed). It had the same idea for the writers. This PR takes only that part.
How
isXYPositionWritein@hyperframes/parsers/gsap-constantsbesidePROPERTY_GROUPS, says whether a write sets x or y. Only those can duplicate each other. An xPercent/yPercent-only set never does.dedupePositionWritesInScript, its recast twin, and the Studio self-heal intryGsapDragInterceptall use it.tryGsapDragInterceptpicked the wrong write: the stale-id re-match took the firstpositionwrite in the fresh parse, which is the set, so the move turned the centring set into keyframes. It now matches only a write of the same kind.x,yand seeking. GSAP clears the whole transform when any part of it is cleared, and the seek only restores what the timeline owns, so the centring vanished from the preview for a few frames until the soft reload (the bench's teleport check caught a 144 px jump on the move and resize rows). The restore after the read now carries every position channel,xPercentandyPercentincluded.Test plan
gsapWriter.parity.test.ts: a centring set plus an x/y tween comes out unchanged from both writers. Fails on main.gsapRuntimeBridge.test.ts: a drag with a centring set and a live x/y tween runs no consolidate and edits only the tween (fails on main), and a second x/y write is still consolidated.clearProps, so a unit test there cannot see it.--filter '^(move|nudge|resize)-tween-xpercent-'(36 cases) on Linux: every gated metric passes in all 36 (drop, reload, render, undo, tracking, press).move-tween-xpercent-r0-root-z100drop went from 144.24 px on main to 0.move,nudgeandresize-tween-xpercentcase that failed on main), 0 regressed. Those 34 are banked from that run's artifactbaseline.json, byte for byte, and a local replay of the gate on the banked file passes.Captures: the bench fixture
move-tween-xpercent-r0-root-z100(a 240x160 box atleft: 50%; top: 50%with the centring set and an x/y tween), driven by the bench's own drag. Left: the frame at pointer release. Right: the same view once the save has landed.Before
Saved script: the
gsap.set("#target", { xPercent: -50, yPercent: -50 })line is gone.After
Saved script: the centring set is still there, and the move is a keyframe on the tween.