Added Close Button#8
Closed
CarsenGafford2 wants to merge 1 commit into
Closed
Conversation
Added a Close Button so the application can be both closed as well as minimized to the toolbar.
Owner
|
Thanks for the PR, but the close button was intentionally removed in commit 3f5168a to better align the app with the behavior of a native system tray utility. If someone wants to close the app, they can do so through the tray icon (right-click → Exit Kasio), which is a common pattern for this type of application. Given that design direction, I’m going to pass on adding the close button back in for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a Close Button so the application can be both closed as well as minimized to the toolbar.