Extract keypad panels into separate classes#6
Merged
Conversation
Move scientific and basic keypad UI construction out of CalculatorView into new ScientificKeypadPanel and BasicKeypadPanel components. The panels encapsulate layout and button creation (append/wrap lists and control buttons) and expose getters for buttons; CalculatorView now instantiates these panels, aggregates their append/wrap button lists, and obtains references to AllClear/Del/Equals/Ans buttons from BasicKeypadPanel. This refactor reduces CalculatorView size and centralizes keypad layout logic with no functional behavior changes.
Owner
|
Everything looks perfect. Thank you for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Move scientific and basic keypad UI construction out of CalculatorView into new ScientificKeypadPanel and BasicKeypadPanel components. The panels encapsulate layout and button creation (append/wrap lists and control buttons) and expose getters for buttons; CalculatorView now instantiates these panels, aggregates their append/wrap button lists, and obtains references to AllClear/Del/Equals/Ans buttons from BasicKeypadPanel. This refactor reduces CalculatorView size and centralizes keypad layout logic with no functional behavior changes.
Related Issue
Closes #5