Skip to content

fix: explain zig version requirement on build failure - #3931

Merged
Pimpmuckl merged 1 commit into
masterfrom
fix/zig-build-version-hint
Sep 11, 2026
Merged

fix: explain zig version requirement on build failure#3931
Pimpmuckl merged 1 commit into
masterfrom
fix/zig-build-version-hint

Conversation

@Pimpmuckl

Copy link
Copy Markdown
Collaborator

When just build fails with an incompatible Zig installation, the final error now states that Herdr requires Zig 0.16.0 and suggests checking zig version or setting ZIG to the correct binary. This only extends the existing failure message (one file, +3/-1); it also appears for other Zig build failures.

Validation: just build passes on Windows with Zig 0.16.0; cargo fmt --check and git diff --check pass. A directly compiled build script with a deliberately failing compiler invocation confirms the hint is printed. Full just check is unnecessary for this message-only change; no build logic changes.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: d6db47de-42a6-40d5-a3d7-050cabf8dcd4

📥 Commits

Reviewing files that changed from the base of the PR and between 6e7d415 and 472d491.

📒 Files selected for processing (1)
  • build.rs

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The zig build failure assertion now states that Zig 0.16.0 is required. It also directs developers to check zig version or set ZIG to a compatible binary.

Suggested reviewers: ogulcancelik

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 472d4

This documentation-only build guidance change has no remaining merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: explaining the Zig version requirement when the build fails.
Description check ✅ Passed The description directly explains the updated Zig build failure message, its scope, and validation results.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kangal-bot

Copy link
Copy Markdown
Collaborator

@coderabbitai review
@greptileai

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

@kangal-bot I will review the changes in #3931.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@greptile-apps

greptile-apps Bot commented Sep 11, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge because it only adds accurate guidance while preserving the underlying Zig build diagnostics.

Summary

  • Identifies Zig 0.16.0 as the required toolchain.
  • Suggests checking zig version or configuring ZIG.
  • Does not alter build execution or error propagation.

Reviews (1) · Last reviewed commit: "fix: explain zig version requirement on ..."

@Pimpmuckl
Pimpmuckl merged commit 61ca85d into master Sep 11, 2026
9 checks passed
@Pimpmuckl
Pimpmuckl deleted the fix/zig-build-version-hint branch September 11, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants