fix(linux): identify Herdr desktop notifications

[akbash-bot]

Issue

Linux system notifications appear under the generic Notify Send application name. Users cannot identify Herdr as the sender when notification text is generic.

Problem

Herdr passed only the notification title and body to notify-send. The notification daemon therefore used the helper's default application name.

How did we fix it?

Herdr now passes --app-name Herdr for Linux system notifications. The existing -- separator still protects titles that begin with an option character. Other delivery modes and platforms are unchanged.

Verification

The command-capture regression failed before the change because the application-name arguments were absent. The same test now passes and preserves title/body ordering and option separation. All PR checks pass on Linux, macOS, and Windows. A local broad run reached 3,056 passing tests before two environment-specific failures in a root-permission test and a live-handoff server-start test.

refs #3638

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 871d7023-7902-484d-94a9-0058f769de07

📥 Commits

Reviewing files that changed from the base of the PR and between 7916be1 and 82c5da8.

📒 Files selected for processing (1)

• src/platform/linux.rs

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.

---

📝 Walkthrough

Walkthrough

Linux desktop notifications now pass --app-name Herdr to notify-send before the title separator. The notification test was renamed and now expects --app-name, Herdr, --, the title, and the body.

Suggested reviewers: ogulcancelik, pimpmuckl

Merge Risk: ⚪ Minimal · up to 82c5d

Linux desktop notifications will identify themselves as Herdr while preserving safe handling and ordering of notification titles and bodies. The implementation and its focused regression coverage support merging without an outstanding current-head risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely describes the main change: identifying Herdr as the Linux desktop notification source.
Description check	✅ Passed	The description directly explains the Linux notification issue, the --app-name Herdr fix, test coverage, and verification results.

• Fix all pre-merge checks with AI

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[kangal-bot]

@coderabbitai review
@greptileai

[coderabbitai]

@kangal-bot I will review pull request #3639.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[greptile-apps]

Greptile Summary

This PR identifies Linux desktop notifications as originating from Herdr.

• Adds --app-name Herdr to the notify-send invocation.
• Preserves the -- separator and title/body argument ordering.
• Updates the command-capture regression test to verify the application name and option-like title handling.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or quality issues identified.

The notify-send arguments follow the expected CLI ordering, retain protection for option-like titles, and are covered by a focused command-capture regression test.

Important Files Changed

Filename	Overview
src/platform/linux.rs	Adds the Herdr application name to Linux system notifications and updates the focused argument-ordering test.

_{Reviews (1): Last reviewed commit: "fix(linux): identify Herdr desktop notif..." | Re-trigger Greptile}