Skip to content

feat(notes): unify notes, My Notes and Action Items into one flow - #8

Merged
hechi merged 4 commits into
mainfrom
feat/unify-notes-and-action-items
Nov 9, 2026
Merged

hechi merged 4 commits into
mainfrom
feat/unify-notes-and-action-items

Conversation

@hechi

@hechi hechi commented Nov 9, 2026

Copy link
Copy Markdown
Owner

Summary

Notes (side panel), My Notes and Action Items felt like three unrelated screens.
This PR makes them behave as one flow: a note is something to remember, and it can
be completed or promoted to an action item. Action Items now clearly separates
"mine" from "my reports'".

What changed

Notes (side panel + My Notes)

  • New Complete action on notes (INBOX -> DONE), styled like the action item button.
  • "Convert to TODO" is now "Make action item".
  • Friendly status labels (Note / Done / Action item / Archived); done notes are struck through.
  • My Notes defaults to the Active filter and has a new Done filter. Converted
    notes no longer show twice (they live under "My action items"; the All filter still shows them).

My Notes page

  • Two sections: Notes and My action items (own open items only), with
    Complete / Cancel / Delete on the action items.
  • The side panel is unchanged apart from Complete (no action items there, by request).

Action Items page

  • Mine / My team tabs with counts. My team groups items by report name.
  • Cards show "You" or the person's name, "re: " for your items about a report,
    and a "from note" badge. Names come from the existing people list.

Tags

  • A note's tag is now copied onto the action item (new action_items.tag column),
    so it no longer disappears on "Make action item".

Consistent buttons

  • One shared style (components/ui/itemButtonStyle.ts) with a fixed control height for
    every button and the due-date input in both cards. Note labels got matching icons.

Bug fixes found along the way

  • Drag-and-drop reorder: the page briefly defaulted to "All", so drop indexes did not
    match the backend's active-only ordering. Reordering is now only enabled on the
    unfiltered Active list (not under All / Done / Archived / a tag filter).

Backend

  • QuickNoteStatus.DONE, QuickNote.complete(), CompleteQuickNoteCommand,
    POST /api/v1/quick-notes/{id}/complete (scoped by userId, 404 on foreign notes).
  • ActionItem.tag carried through domain, entity, mapper, response and convertQuickNote.
  • Migration V20261109120000__add_tag_to_action_items.sql adds the column and
    backfills tags from originating notes. No existing migration was modified.

Testing

  • Backend ./gradlew test: 1679 tests, 0 failures (includes Testcontainers integration
    tests that apply the new migration).
  • Frontend jest: 130 suites, 1430 tests, 0 failures. New coverage: complete flow,
    tabs and grouping, my-action-items section, default filter and reorder rules,
    tag chip, and a button style consistency test.
  • tsc: no errors in touched files (existing unrelated errors remain in settings tests).
  • README and PROGRESS updated.

Known limitations / reviewer notes

  • Not visually verified in a browser. The app is behind sign-in and I had no session,
    so layout and button sizing were checked via tests only. Please eyeball both cards.
  • The Mine / My team split is client-side over the first 100 items, and /action-items
    pagination was removed. Fine at current scale; a larger list needs a server-side filter.
  • Person names resolve for the first 100 people.
  • "Delete" on an action item has no confirmation (same as the Action Items page before).

hechi added 4 commits November 9, 2026 23:27
Add DONE status and complete endpoint for notes, Make action item wording, Mine/My team tabs with person names, and My action items section on My Notes.
Default My Notes to Active filter, limit reorder to the unfiltered active list, and carry the note tag onto the action item (new action_items.tag column).
@hechi
hechi merged commit dc34737 into main Nov 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant