Repository navigation
feat(notes): unify notes, My Notes and Action Items into one flow - #8
Merged
Merged
Conversation
Add DONE status and complete endpoint for notes, Make action item wording, Mine/My team tabs with person names, and My action items section on My Notes.
Default My Notes to Active filter, limit reorder to the unfiltered active list, and carry the note tag onto the action item (new action_items.tag column).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes (side panel), My Notes and Action Items felt like three unrelated screens.
This PR makes them behave as one flow: a note is something to remember, and it can
be completed or promoted to an action item. Action Items now clearly separates
"mine" from "my reports'".
What changed
Notes (side panel + My Notes)
INBOX -> DONE), styled like the action item button.notes no longer show twice (they live under "My action items"; the All filter still shows them).
My Notes page
Complete / Cancel / Delete on the action items.
Action Items page
and a "from note" badge. Names come from the existing people list.
Tags
action_items.tagcolumn),so it no longer disappears on "Make action item".
Consistent buttons
components/ui/itemButtonStyle.ts) with a fixed control height forevery button and the due-date input in both cards. Note labels got matching icons.
Bug fixes found along the way
match the backend's active-only ordering. Reordering is now only enabled on the
unfiltered Active list (not under All / Done / Archived / a tag filter).
Backend
QuickNoteStatus.DONE,QuickNote.complete(),CompleteQuickNoteCommand,POST /api/v1/quick-notes/{id}/complete(scoped byuserId, 404 on foreign notes).ActionItem.tagcarried through domain, entity, mapper, response andconvertQuickNote.V20261109120000__add_tag_to_action_items.sqladds the column andbackfills tags from originating notes. No existing migration was modified.
Testing
./gradlew test: 1679 tests, 0 failures (includes Testcontainers integrationtests that apply the new migration).
jest: 130 suites, 1430 tests, 0 failures. New coverage: complete flow,tabs and grouping, my-action-items section, default filter and reorder rules,
tag chip, and a button style consistency test.
tsc: no errors in touched files (existing unrelated errors remain in settings tests).Known limitations / reviewer notes
so layout and button sizing were checked via tests only. Please eyeball both cards.
/action-itemspagination was removed. Fine at current scale; a larger list needs a server-side filter.