Address ls "no cached counter a found" 500 errors - #245
Merged
Conversation
- As noted in an added comment, a search with no results can precipitate this error - I believe it likely that only zero-results queries cause it. - Trying to recover the counter is pointless because the interleaver (which is the source) is never invoked. - It is okay to leave counter a uninitialized because there is nothing to count. - Hence, the ASSERT was removed. User will get "no results" instead of 500.
…no cached counter a" 500.
…ing whitespace (remove TABs).
carylwyatt
approved these changes
Aug 7, 2026
carylwyatt
left a comment
carylwyatt
left a comment
Member
There was a problem hiding this comment.
This looks good to me! Thanks to your detailed instructions, this was very easy to test. Great work. 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is never invoked.
ASSERTwas removed. User will get "no results" instead of 500.I've added a basic unit test file. It includes a test for the condition in question, which dies if the ASSERT is put back in place.
Minor reformatting also done.
Reviewer
This is staged on dev-2. Compare
vs
You can make up your own production crasher for comparison as long as the
pnpage number parameter is=3or more, either with a no-results query or for example you could edit a facet likefacet=language008_full:"French Dressing". Have fun!