Skip to content

Add Storybook stories for remaining PT sidebar/toolbar panels - #242

Merged
eumalin merged 1 commit into
mainfrom
storybook-sidebar-panels
Jul 28, 2026
Merged

Add Storybook stories for remaining PT sidebar/toolbar panels#242
eumalin merged 1 commit into
mainfrom
storybook-sidebar-panels

Conversation

@eumalin

@eumalin eumalin commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Storybook

Storybook stories for the rest of PT's sidebar/toolbar panels. In #232 I got Storybook bootstrapped and did the Panel component as a proof of concept. This PR covers the actual panels: ViewerToolbar, SharePanel, MetadataPanel, AccessStatusPanel, DownloadPanel, SearchInItemPanel, JumpToSectionPanel, GetThisItemPanel, and CollectionsPanel. That's all nine things that live in the #controls accordion plus the toolbar. AI assisted

Screenshots

ViewerToolbar:
viewertoolbar

SharePanel:
sharepanel

MetadataPanel:
metadatapanel

AccessStatusPanel (emergency access variant):
accessstatuspanel

DownloadPanel:
downloadpanel

SearchInItemPanel:
searchinitempanel

JumpToSectionPanel:
jumptosectionpanel

GetThisItemPanel:
getthisitempanel

CollectionsPanel:
collectionspanel

How to check it out

docker compose --profile storybook up

or locally from pt/web/firebird: npm run storybook.

@eumalin
eumalin marked this pull request as ready for review July 21, 2026 12:25
@eumalin
eumalin requested a review from carylwyatt July 21, 2026 12:25

@carylwyatt carylwyatt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so great!

We tried to use svelte story syntax when we first added storybook to firebird back in 2023, but it was such a mess and I've never tried again. 🙈 I love to see it here in page turner, and I hope it wasn't a giant pain in the ass.

Speaking of pains in the ass, I see you implemented some method mocks of the HT global in the manifest decorator (lots of functionality depends on that global!). We have a PingCallbackDecorator in firebird which does a lot of similar things in case you need some of these in the future. https://github.com/hathitrust/firebird-common/blob/main/src/js/decorators/PingCallbackDecorator.svelte

This is such a great starting place for these stories, and I know we will use them as we flesh out the design system in the future. Thank you so much!

@eumalin
eumalin merged commit 32ff14d into main Jul 28, 2026
3 checks passed
@eumalin
eumalin deleted the storybook-sidebar-panels branch July 28, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants