Skip to content

fix(security): update vulnerable Go deps (grpc CRITICAL + 30 HIGH) - #24

Merged
hgiasac merged 5 commits into
mainfrom
gavin/vuln-dep-updates-2026-11
Nov 18, 2026
Merged

hgiasac merged 5 commits into
mainfrom
gavin/vuln-dep-updates-2026-11

Conversation

@GavinRay97

Copy link
Copy Markdown
Member

Summary

Updates the vulnerable Go dependencies Trivy reports in the released ghcr.io/hasura/ndc-storage:v0.1.1 image (ndc-cli binary): 1 CRITICAL, 30 HIGH → 0.

Module Before After CVEs
google.golang.org/grpc 1.75.1 1.85.0 CVE-2026-33186 (CRITICAL), CVE-2026-84304, CVE-2026-84445, GHSA-hrxh-6v49-42gf
golang.org/x/net 0.44.0 0.62.0 7 HIGH incl. CVE-2026-78661
golang.org/x/crypto 0.42.0 0.59.0 11 HIGH
golang.org/x/text 0.29.0 0.44.0 CVE-2026-56851, CVE-2026-56852
go.opentelemetry.io/otel (+ sdk, sdk/log, exporters) 1.38.0 1.47.0 CVE-2026-29181, CVE-2026-24051, CVE-2026-39883
github.com/go-jose/go-jose/v4 4.1.2 4.1.9 CVE-2026-34986, CVE-2026-116587
github.com/klauspost/compress 1.18.0 1.20.4 CVE-2026-63209
github.com/buger/jsonparser 1.1.1 1.6.1 CVE-2026-32285

The updated modules require a newer Go, so the go directive moves from 1.24.7 to 1.26.0 and the Docker builder image from golang:1.24 to golang:1.27.4. CI reads the Go version from go.mod (go-version-file), so it follows automatically.

The otel/sdk/log exporters had to move together with the otel core. Bumping core alone breaks the build: undefined: log.KeyValue in sdk/log v0.14.

Verification

  • go build ./... passes.
  • go test ./...: connector package tests (TestConnector, TestConnectorQueries, TestMax*SizeValidation) fail identically on main (they need MinIO/Azurite/GCS emulators from docker-compose); storage/common, encoding and jsonschema pass
  • Built the Docker image locally and scanned it with Trivy 0.76.2 (DB as of 2026-11-17, HIGH/CRITICAL): 0 findings.

This is part of the DDN connector vulnerability sweep for the non-ndc-jdbc connectors. Once it merges, a new release tag publishes the patched image.

Originating bot: https://prompt.ql.app/project/hasuraql/promptql-playground/thread/3a3bf742-a20b-4003-b350-59948bbd1585

- grpc 1.75.1 -> 1.85.0 (CVE-2026-33186 CRITICAL + 3 HIGH)
- golang.org/x/{net,crypto,text}, otel 1.38 -> 1.47, go-jose 4.1.9,
  klauspost/compress 1.20.4, buger/jsonparser 1.6.1
- go directive 1.24.7 -> 1.26.0 (required by updated deps); builder golang:1.27.4
@hgiasac
hgiasac marked this pull request as ready for review November 18, 2026 08:50
@hgiasac
hgiasac added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit 443e47b Nov 18, 2026
1 check failed
@hgiasac
hgiasac deleted the gavin/vuln-dep-updates-2026-11 branch November 18, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants