Repository navigation
fix(security): update vulnerable Go deps (grpc CRITICAL + 30 HIGH) - #24
Merged
Merged
Conversation
- grpc 1.75.1 -> 1.85.0 (CVE-2026-33186 CRITICAL + 3 HIGH) - golang.org/x/{net,crypto,text}, otel 1.38 -> 1.47, go-jose 4.1.9, klauspost/compress 1.20.4, buger/jsonparser 1.6.1 - go directive 1.24.7 -> 1.26.0 (required by updated deps); builder golang:1.27.4
hgiasac
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the vulnerable Go dependencies Trivy reports in the released
ghcr.io/hasura/ndc-storage:v0.1.1image (ndc-clibinary): 1 CRITICAL, 30 HIGH → 0.google.golang.org/grpcgolang.org/x/netgolang.org/x/cryptogolang.org/x/textgo.opentelemetry.io/otel(+ sdk, sdk/log, exporters)github.com/go-jose/go-jose/v4github.com/klauspost/compressgithub.com/buger/jsonparserThe updated modules require a newer Go, so the
godirective moves from 1.24.7 to 1.26.0 and the Docker builder image fromgolang:1.24togolang:1.27.4. CI reads the Go version fromgo.mod(go-version-file), so it follows automatically.The
otel/sdk/logexporters had to move together with the otel core. Bumping core alone breaks the build:undefined: log.KeyValueinsdk/logv0.14.Verification
go build ./...passes.go test ./...:connectorpackage tests (TestConnector,TestConnectorQueries,TestMax*SizeValidation) fail identically onmain(they need MinIO/Azurite/GCS emulators from docker-compose);storage/common,encodingandjsonschemapassThis is part of the DDN connector vulnerability sweep for the non-
ndc-jdbcconnectors. Once it merges, a new release tag publishes the patched image.Originating bot: https://prompt.ql.app/project/hasuraql/promptql-playground/thread/3a3bf742-a20b-4003-b350-59948bbd1585