FE-827: Orchestrator promote-back only adopts a target that is a repo root#183
Merged
kostandinang merged 1 commit intoJun 9, 2026
Conversation
promoteGreenfieldRun's repo check used `git rev-parse --is-inside-work-tree`, which walks up — so an empty --out target nested inside an enclosing repo was treated as that repo and silently committed into it (checkout -b + add -A + commit on the parent). Now `isGitRepoRoot` compares `git rev-parse --show-toplevel` (realpath, for macOS /var→/private/var) to the target: only a true repo root takes the cook/<runId> branch path; a nested-but-empty target is git-init'd as its own fresh repo, leaving the enclosing repo untouched. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This was referenced Jun 9, 2026
Contributor
Author
kostandinang
merged commit b7034b5
into
ka/fe-827-greenfield-single-tree
4 checks passed
kostandinang
changed the title
This was referenced Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
promoteGreenfieldRun's repo check used
git rev-parse --is-inside-work-tree,which walks up — so an empty --out target nested inside an enclosing repo was
treated as that repo and silently committed into it (checkout -b + add -A +
commit on the parent). Now
isGitRepoRootcomparesgit rev-parse --show-toplevel(realpath, for macOS /var→/private/var) to the target: only atrue repo root takes the cook/ branch path; a nested-but-empty target is
git-init'd as its own fresh repo, leaving the enclosing repo untouched.
🤖 Generated with Claude Code