fix: apply default branding and silence fetch toasts#6324
Merged
Conversation
Test Results 32 files + 29 64 suites - 397 4m 14s ⏱️ + 4m 14s For more details on these failures, see this check. Results for commit cbddba2. ± Comparison against base commit e36831b. ♻️ This comment has been updated with latest results. |
Pyatakov
force-pushed
the
fix/branding-default-load-toast-spam
branch
from
4f5f063 to
fdea614
Compare
Add a client-side default branding fallback and mark the branding fetch silent so an unreachable backend no longer leaves the app unbranded or spams error toasts. Share one in-flight request across the components that load branding on startup. Signed-off-by: Alex Piatakov <alex.piatakov@swirldslabs.com>
Pyatakov
force-pushed
the
fix/branding-default-load-toast-spam
branch
from
fdea614 to
cbddba2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #6323
GET /api/v1/brandingis slow, errors, or returns no usable data.