Theme change functionality#22
Conversation
hasancse91
requested review from
hasibul-hasan-shuvo,
kmmuntasir and
shafayathossain
hasancse91
left a comment
hasancse91
left a comment
There was a problem hiding this comment.
We need more flexibility to manage every widget color of the app. Cannot rely on GetX's basic theme changing. Please update your PR to achieve more customization option. For example below screenshots. item card's background should be dark color and text should be light color.
| import 'app_colors.dart'; | ||
|
|
||
| class AppThemes { | ||
| // light theme configurations |
There was a problem hiding this comment.
Our code should be self explanatory. don't need to add unnecessary comment.
| ); | ||
| } | ||
|
|
||
| // dark theme configurations |
There was a problem hiding this comment.
Our code should be self explanatory. don't need to add unnecessary comment.
| // Get themeMode info from local storage and return current ThemeMode | ||
| Future<ThemeMode> get themeMode async => | ||
| await _loadThemeFromSharedPref() ? ThemeMode.dark : ThemeMode.light; | ||
|
|
||
| // Load themeMode from local storage | ||
| Future<bool> _loadThemeFromSharedPref() async { | ||
| return await _preferenceManager.getBool(themeModeKey); | ||
| } | ||
|
|
||
| // Load isDarkMode status from local storage | ||
| Future<bool> getCurrentThemeMode() async { | ||
| return await _preferenceManager.getBool(themeModeKey); | ||
| } | ||
|
|
||
| // change isDarkMode status in local storage | ||
| changeThemeMode(bool isDarkMode) { | ||
| _preferenceManager.setBool(themeModeKey, isDarkMode); | ||
| } |
There was a problem hiding this comment.
Our code should be self explanatory. don't need to add unnecessary comment.
| getCurrentThemeMode() async { | ||
| currentThemeMode.value = await themeService.themeMode; | ||
| } | ||
|
|
||
| setCurrentThemeMode(ThemeMode themeMode) { | ||
| currentThemeMode.value = themeMode; | ||
| } |
Here the background color of the cards are static colors from AppColors file, to make it dynamic we need to use colors from the theme regardless of we use GetX theme or our custom theme class. Should I refactor them to use colors from theme? |
4 participants
Why? (ticket link or issue description)
#16
What was done and how?
Theme changing was implemented with GetX
Anything special? (optional)