Skip to content

added Oxford comma to sitemap text#8651

Open
emoore36 wants to merge 1 commit into
hackforla:gh-pagesfrom
emoore36:correct-comma-site-map-8514
Open

added Oxford comma to sitemap text#8651
emoore36 wants to merge 1 commit into
hackforla:gh-pagesfrom
emoore36:correct-comma-site-map-8514

Conversation

@emoore36
Copy link
Copy Markdown
Member

@emoore36 emoore36 commented May 24, 2026

Fixes #8514

What changes did you make?

  • added comma to sitemap text

Why did you make the changes (we will use this info to test)?

  • to increase sitemap page readability

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied
Site Map - Before image
Visuals after changes are applied
Site Map - After image

@github-actions
Copy link
Copy Markdown

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b emoore36-correct-comma-site-map-8514 gh-pages
git pull https://github.com/emoore36/website.git correct-comma-site-map-8514

@github-actions github-actions Bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe P-Feature: Sitemap https://www.hackforla.org/sitemap/ size: 0.25pt Can be done in 0.5 to 1.5 hours feature: spelling labels May 24, 2026
@egcuriel egcuriel requested review from egcuriel and removed request for egcuriel May 26, 2026 03:54
@egcuriel
Copy link
Copy Markdown
Member

Review ETA: 5/27/26 EOD
Availability: M-Sun (5 pm - 11 pm)

Copy link
Copy Markdown
Member

@egcuriel egcuriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @emoore36 !

I have reviewed this pull request and verified the following:

PR Verification:

  • Pull Request uses the correct branch
  • Original issue is linked
  • Screenshots included
    • Before
    • After

Technical Verification:

  • Issue requirements are addressed correctly
  • Changes are accurately represented locally across viewports:
    • Desktop
    • Mobile
  • No new console errors or warnings present
  • No unresolved CodeQL alerts

Notes:

  • Everything looks good on my end, keep up the good work!

Status: PR Approved

@mocodesss mocodesss self-requested a review May 26, 2026 12:20
@mocodesss
Copy link
Copy Markdown
Member

Review ETA: 5/27/26
Availability: Tuesday and Thursday after 4pm PT.

Copy link
Copy Markdown
Member

@mocodesss mocodesss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job here! This is a very clean PR. Keep up the good work!

PR checklist:

  • The issue has been correctly linked.
  • In the issue, you've correctly assigned yourself.
  • In the issue, you've correctly set the project status.
  • In the issue, action items have correctly been checked off.
  • The merge from and to branches have been correctly set.
  • The CodeQL alerts have been correctly checked off.
  • Relevant before and after pictures included.
  • Tested changes... works on desktop and mobile.

One thing I will note: This is not actually an Oxford comma. An Oxford comma separates the last item in a list of items, before the "and" or "or". The addition of the comma is correct, but it is just a comma between two independent clauses. So, the naming of this PR is a little off, but other than that, nice job!

@github-project-automation github-project-automation Bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: spelling good first issue Good for newcomers P-Feature: Sitemap https://www.hackforla.org/sitemap/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Status: PRs ✅ waiting for merge team

Development

Successfully merging this pull request may close these issues.

Correct Comma in Site Map Page

3 participants