Skip to content

Fix get mutating endpoints #5191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lindseydew merged 3 commits into from
Nov 5, 2026
Merged

Fix get mutating endpoints #5191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8ce501
Delete the lease reindex endpoint
lindseydew Nov 5, 2026
7642f14
Make reindexForContent a POST request
lindseydew Nov 5, 2026
1888d9b
Remove reindex from routes
lindseydew Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions leases/app/controllers/MediaLeaseController.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,17 +83,6 @@ class MediaLeaseController(auth: Authentication, store: LeaseStore, config: Leas

def index = auth { _ => indexResponse }

def reindex = auth.async { _ =>
for {
reindexRequests <- store.forEach { leases =>
leases
.foldLeft(Set[String]())((ids, lease) => ids + lease.mediaId)
.map(notifications.sendReindexLeases)
}
_ <- Future.sequence(reindexRequests)
} yield Accepted
}

def postLease = auth.async(parse.json) { implicit request =>
request.body.validate[MediaLease] match {
case JsSuccess(mediaLease, _) =>
Expand Down
1 change: 0 additions & 1 deletion leases/conf/routes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ PUT /leases/media/:id controllers.MediaLeaseCont
POST /leases/media/:id controllers.MediaLeaseController.addLeasesForMedia(id: String)

# Leases
GET /leases/reindex controllers.MediaLeaseController.reindex
GET /leases/:id controllers.MediaLeaseController.getLease(id: String)
DELETE /leases/:id controllers.MediaLeaseController.deleteLease(id: String)
POST /leases controllers.MediaLeaseController.postLease
Expand Down
2 changes: 1 addition & 1 deletion usage/conf/routes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ POST /usages/front controllers.UsageApi.set
POST /usages/download controllers.UsageApi.setDownloadUsages()
POST /usages/child controllers.UsageApi.setChildUsages()
PUT /usages/status/update/:mediaId/*usageId controllers.UsageApi.updateUsageStatus(mediaId: String, usageId: String)
GET /usages/digital/content/*contentId/reindex controllers.UsageApi.reindexForContent(contentId: String)
POST /usages/digital/content/*contentId/reindex controllers.UsageApi.reindexForContent(contentId: String)

# Management
GET /management/healthcheck com.gu.mediaservice.lib.management.Management.healthCheck
Expand Down
Loading