Conversation
|
@ShreyaLbs is attempting to deploy a commit to the awindsr's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The leaderboard table was skipping ranks 1, 2, and 3.
Users who wanted to see the full leaderboard in list format
could not do so because the top 3 were only shown in the
visual podium and completely absent from the table below.
Root Cause
In
Leaderboard.tsx, the table was receivingcurrentLeaderboard.slice(topPlayerCount)which cut offthe first 3 entries before passing data to
LeaderboardTable.Fix
Changed
remainingPlayersto use the fullcurrentLeaderboardarray so all ranks including 1, 2, and 3 appear in the table.
Changes
src/modules/Dashboard/modules/LeaderBoard/components/Leaderboard.tsxcurrentLeaderboard.slice(topPlayerCount)→currentLeaderboardSteps to Reproduce
Expected Behavior
Table should show all ranks starting from 1 so the
full leaderboard is visible in list format.