Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 9, 2026 21:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reusing the same timer in nested, same-thread
withblocks currently overwrites its outer start time. The inner exit then clears it, so the outer exit raisesRuntimeErrorinstead of reporting its duration. If the inner block raises, that runtime error also replaces the original exception.Save enclosing start times while the context manager is active and restore the prior state before reporting each elapsed duration. This also leaves the timer correctly exited when the output callback raises. Ordinary one-shot and sequential use, decorator behavior, and disabled output are unchanged.
Add five deterministic regressions for three-level nesting, exception identity, recovery after a caught inner exception and sequential reuse, disabled output, and a failing output callback. Every added test fails on the unmodified implementation.
Validation against
2e09b0dc674bc4375f34b5254d15569569603ee1on Linux:git diff --checkpass.Other Python versions and operating systems remain for hosted CI; no hosted pass is claimed.
AI assistance was used to prepare the implementation and regression tests.