Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #118.
Both
ic(...)andic.format(...)keep their own frame in a local variable. That creates a reference cycle, so arguments and other locals in the calling function can stay alive until cyclic garbage collection runs. The retention also occurs with a trivial formatter that never callsexecuting.Delete the frame reference in
finallyso it is released after normal output and when formatting or output raises. This breaks the cycle without adding a garbage-collection sweep to each call.Validation on Windows with CPython 3.12.14:
test_context_abs_path_multi_line, whose helper splits a Windows drive-letter path on:. The same error occurs on the unchanged source.The lifetime tests require CPython's reference-counting behavior and are skipped on other interpreters. I have not reproduced the Qt application from #118; this change addresses the independently reproduced frame-retention problem. Hosted checks have not run yet.