Skip to content

[visual-qa] EditVertex right-click insert misses CIRCULARSTRING because locater hits chords not arcs #99

Description

@grootstebozewolf

Part of #68. Follow-on to #82 (odd-count insert).

Observed

Move/add/delete vertex, right-click add on a CIRCULARSTRING (or GEOMETRYCOLLECTION of one) clicks the drawn arc and nothing is inserted. The same click on the control chord (as in #82) inserts.

Cause: GeometryPointLocater.checkSegment uses LineSegment (control chords). The painted geometry is the circular arc, which can sit far from the chord. First-contact: right-click does not add.

Expected

locateNonVertexPoint hits the circular arc (3-control window), not the chord. Insert still splits that arc (net +2, odd count, type kept). A click on the chord that is far from the arc does not insert.

Not

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions