fix(design)!: scope callout body paragraph margins to direct children - #4617
Merged
Conversation
BREAKING CHANGE: `DaffCalloutComponent` no longer resets the margins of paragraphs nested inside child components within `[daffCalloutBody]`. Previously the first and last `<p>` under the body received `margin-top: 0` and `margin-bottom: 0` at any depth. The reset now applies only to paragraphs that are direct children of `[daffCalloutBody]`. If you relied on the old behavior to flatten spacing in nested content, apply those margins in your own styles.
xelaint
added
package: design
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Current behavior
Fixes: #4616
New behavior
Breaking change?
BREAKING CHANGE:
DaffCalloutComponentno longer resets the margins of paragraphs nested inside child components within[daffCalloutBody]. Previously the first and last<p>under the body receivedmargin-top: 0andmargin-bottom: 0at any depth. The reset now applies only to paragraphs that are direct children of[daffCalloutBody]. If you relied on the old behavior to flatten spacing in nested content, apply those margins in your own styles.Additional context