fix: Iter yields all rows instead of only the first#41
Merged
klaidliadon merged 1 commit intomasterfrom Apr 7, 2026
Merged
Conversation
ScanOne closes the underlying pgx.Rows after scanning, which caused the iterator to stop after the first row. Switch to ScanRow which scans the current row without closing the cursor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Iterused scany'sScanOnewhich closespgx.Rowsafter scanning the first row, making the iterator yield only one row then stop.ScanOnewithScanRow, which scans the current row without closing the cursor.TestIter— inserts 100 rows, iterates withIter, asserts count is 100.Test plan
TestIterpasses (100 rows streamed)