gftools-gen-stat: allow a builder config file as STAT source - #1209
Open
RickyDaMa wants to merge 3 commits into
Open
gftools-gen-stat: allow a builder config file as STAT source#1209RickyDaMa wants to merge 3 commits into
gftools-gen-stat: allow a builder config file as STAT source#1209RickyDaMa wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I discovered the other day, if you aren't using the default Google Fonts recipe provider, your in-line STAT definition within your
config.yamlisn't respected by thebuildStatoperation; it'll always auto-generate.How the in-line STAT works with the Google Fonts recipe provider is a bit hacky and not simple to replicate without a full-blown custom recipe provider. So this PR takes a path with less resistance: by having
gftools-gen-statcheck for a "stat" key in the source YAML, and if found it uses its value instead of the full document. So now the following works:Could I have just put the STAT definition in a separate file? Yes, and by all means reject this PR on that basis. But to me needing a separate
stat.yamldoesn't feel very intuitive when you're transitioning from the default recipe builder.I could look into having
buildStatsupport a$srckey if that's preferred over rawargs. It's just more work then to integrate this with the existing Google Fonts recipe provider (which requires zero modifications with this PR as-is).I also snuck in two unrelated changes: allowing STAT flags to be hex ints (I can remove this change if you want), and I also removed a debug print lying around in
gftools-gen-stat.