Conversation
rsheeter
force-pushed
the
orch
branch
4 times, most recently
from
March 10, 2023 06:05
ceb5273 to
86b6ab6
Compare
rsheeter
marked this pull request as ready for review
March 10, 2023 06:09
rsheeter
changed the title
cmyr
approved these changes
Mar 10, 2023
rsheeter
added this to the
Build a simple variable font that renders in a browser milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upcoming changes, such as merging glyphs, need to be able to read and/or write things not readily expressed as a set of specific ids such as "all glyphs." To accomodate this update read access (previously done for write) controlled by a function rather than a fixed set of identifiers.
Hoisted out of #120 in hopes of turning that into a series of small more reviewable PRs.