feat(bq jdbc): run getStatementType in parallel#12291
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the query task execution logic by moving the ExecutorService from a static member in BigQueryStatement to an instance member in BigQueryConnection. This change allows for per-connection thread pool configuration via a new QueryTaskThreadCount property. Additionally, BigQueryStatement.runQuery now fetches the statement type asynchronously to improve performance. Feedback was provided regarding a unit test assertion that used a hardcoded value inconsistent with the newly defined default constant.
...cloud-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryConnectionTest.java
Show resolved
Hide resolved
logachev
force-pushed
the
kirl/getStatementTypeParallel
branch
from
a634fb9 to
b97c562
Compare
logachev
force-pushed
the
kirl/getStatementTypeParallel
branch
from
b97c562 to
003d7f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core change in this PR:
Running
getStatementTypein parallel with a regular query. It saves ~150ms on small queries (where it takes e2e with reading results ~0.6s). Additionally, even if Job was created, we'll usegetStatementTyperesults (achieved with dry-run) for better performance. SDK doesn't have Job type after query is complete, it still has to query it from BQ (similar ~150ms).Additional change:
Moving Executors to the Connection layer to be shared with all statements within a connection. Removed existing static Executor (from Statement object) due to: