docs: explain syncProcessCwd async contexts#1476
Open
KirtiRamchandani wants to merge 1 commit into
Open
Conversation
antonmedv
approved these changes
May 25, 2026
Collaborator
|
@antongolub looks right and explanatory to me. ptal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #876 notes that the current docs mention
cd()andsyncProcessCwd(), but do not explain the async-context mismatch that can happen whencd()changes the global process directory whilewithin()restores only zx's internal$context.Root cause
The
syncProcessCwd()section only states what the hook does. It does not show howprocess.cwd()can drift from$in separate callbacks, or when users should prefer$.cwdinstead.Solution
Add examples showing the mismatch without the hook and the restored behavior with
syncProcessCwd()enabled, plus guidance to use$.cwdfor zx-only directory changes.Tests run
npm exec --yes prettier -- --check docs/api.mdgit diff --checkFixes #876