fix(cli): detect Deno JSR cli entrypoint#1472
Open
rohan-patnaik wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1383.
What changed
isMain()now recognizes Deno JSR executions where the main module is reported asjsr:@webpod/zx,jsr:@webpod/zx/., orjsr:@webpod/zx/cli.This keeps the existing Node/file-url behavior unchanged, but lets the CLI autorun when
zxis launched through its JSR entrypoint.Why
When running through JSR, Deno does not always expose the CLI as a local file path. The old
isMain()check only handled local file URLs orimport.meta.main, sodeno run jsr:@webpod/zxcould import the module without entering the CLI path.Usage demo
npm buildbefore committing and verified the bundle updates correctly.