feat(impl_jni): add JCA AES-CTR implementation#316
Open
mfazrinizar wants to merge 1 commit into
Open
Conversation
mfazrinizar
force-pushed
the
feat/impl-jni-aes-ctr
branch
2 times, most recently
from
46a4e76 to
05b5ddb
Compare
mfazrinizar
force-pushed
the
feat/impl-jni-aes-ctr
branch
from
05b5ddb to
22a7fc8
Compare
HamdaanAliQuatil
requested changes
Jul 14, 2026
| } | ||
|
|
||
| int _minBigIntAndInt(BigInt value, int limit) { | ||
| // Avoid converting huge counter-space values, such as 2^128, |
Collaborator
There was a problem hiding this comment.
nit: there is trailing whitespace here, which causes dart format --output=none --set-exit-if-changed and git diff --check to fail. please remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the JNI/JCA AES-CTR implementation on top of the existing Android JCA backend skeleton.
This PR implements:
Cipher("AES/CTR/NoPadding")wiring withIvParameterSpecTesting
For the desktop JNI-specific test, run this once first if JNI has not been set up locally:
dart run jni:setupVerified with:
dart analyzedart test test/impl_jni_aesctr_test.dartdart test test/webcrypto_test.dart -p vm -n AES-CTRdart test test/aes_ctr_counter_wrap_test.dartflutter test integration_test/jni_aesctr_test.dart -d emulator-name