ci: add FFI memory-safety test lane#295
Merged
Merged
Conversation
jonasfj
reviewed
Jun 29, 2026
jonasfj
approved these changes
Jul 4, 2026
jonasfj
left a comment
Member
There was a problem hiding this comment.
I think we should consider avoiding the extra GitHub actions job if not strictly necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #278
This adds a focused memory-safety workload for the native FFI path and runs it under Valgrind on Linux CI.
The implementation is split into:
test/ffi/valgrind_test.dart: a VM-only test that skips outside Linux or when Valgrind is unavailable, then launchesthe standalone target under Valgrind.
test/ffi/valgrind_target.dart: a standalone Dart program withoutpackage:test, keeping the monitored processfocused on native crypto operations and memory pressure.
What this covers:
The CI job uses the normal
dart testpath because it supports native build hooks today. Sanitizer support for hook-built code remains blocked upstream, so this starts with Valgrind Memcheck.
Valgrind reports definite and possible leaks but only fails on definite leaks. Possible leaks can include Dart VM
runtime noise, so they remain visible without making the initial CI lane unnecessarily brittle.