Repository navigation
fix: restore viewer state after Quick Look export failure - #5198
Merged
diegoteran merged 1 commit intoOct 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
Related to #4300. Quick Look cannot export that issue's video texture. This change repairs the viewer after the failed conversion; it does not add video texture support to USDZ.
When a page uses
createVideoTexture()and starts Quick Look,USDZExporterrejects because it cannot process the video element. The live model then disappears, its shadow is hidden, a progress activity stays open, and the AR button stays disabled. The cleanup inprepareUSDZ()ran only after a successful export.Restore the model, shadow visibility, and progress activity when export rejects, then re-enable the AR button. The original error still propagates. After the failed AR attempt, users can keep viewing the model and the AR button is available again; Quick Look still does not open for a video texture.
The browser test loads
cube.gltf, assignslottie-logo.mp4through the publiccreateVideoTexture()API, and reaches the exporter without a stub. The same error occurred before and after the fix:THREE.USDZExporter: No valid image data found. Unable to process texture.Before the fix, the AR test printed:
After the fix, the full Chromium suite passed with 411 passed, 0 failed, 23 skipped. The same suite on the base commit passed twice with 410 passed, 0 failed, 23 skipped.
npm run build:tsc -w @google/model-vieweralso passes. WebKit and iOS were not run locally because this host lacks WebKit's system libraries.