fix: retry an environment or skybox URL after a failed load - #5197
Merged
Merged
Conversation
TextureUtils cached the load promise per URL and kept it when the load rejected, so a skybox-image or environment-image URL that failed once (network error, temporary 404) failed again on every later request until the page was reloaded. Drop the cache entry when the load fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
No existing issue.
Anyone who sets
skybox-imageorenvironment-imageto a URL that fails once (a dropped connection, a temporary 404 or CDN error) never gets that URL to load again on the page:TextureUtilscaches the load promise per URL and kept the rejected promise, so every later request for the same URL rejected immediately without fetching. Fixing the server or setting the attribute again did not help until the page was reloaded.The fix removes the cache entry when the load rejects, only if it is still the entry for that load. Successful loads are cached as before.
The new test in
TextureUtils-spec.tsmakes the firstloadEquirectcall fail and checks that a secondgenerateEnvironmentMapAndSkyboxcall with the same URL loads. Without the change the second call rethrows the first error (Error: network error); with it the 14 tests in that spec pass.clang-formatreports no changes for the two files.