Repository navigation
Sync streaming_globber with Go standard library filepath.Glob - #9
Merged
Merged
Conversation
Bring streaming_globber in sync with Go stdlib filepath.Glob updates: - Add early pattern validation via filepath.Match(pattern, "") before initiating directory traversal. - Add streamWithLimit with depth parameter and pathSeparatorsLimit = 10000 to guard against stack exhaustion on deeply nested directories (CVE-2022-30632). - Add TestCVE202230632. References: - CVE-2022-30632 - Go commit: golang/go@ac68c6c - Go CL: https://go.dev/cl/417066 - Go issue: golang/go#53416
Contributor
|
Hey Torben I can't remember if I was still the owner of this repository when I left Google, but if I was I lost control of this repo when I left, so someone else will need to merge this. |
Collaborator
|
Oh hello Brendan 👋 We all three lost control :) we'll get it back somehow by escalating to the right people :) |
Collaborator
Author
|
Hi there :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring streaming_globber in sync with Go stdlib filepath.Glob updates:
References: