Speed up NNX graph flattening by avoiding unnecessary array-ref checks#5523
Open
KookiesNKareem wants to merge 1 commit into
Open
Speed up NNX graph flattening by avoiding unnecessary array-ref checks#5523KookiesNKareem wants to merge 1 commit into
KookiesNKareem wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces Python overhead in NNX graph flattening by avoiding unnecessary
is_array_refchecks in common non-ref paths.Specifically:
_graph_flattenskipsvariablelib.is_array_ref(node)when the node is already known to be a graph node, pytree node, orVariable.variablelib.is_array_reffast-paths runtimeRefobjects and concrete non-ref arrays, while preserving the existingjax.typeoffallback forAbstractRefand traced array cases.This keeps mutable-ref behavior unchanged while reducing repeated calls into JAX abstract-value logic on the hot path.
Perf on a warmed no-op
nnx.jitgraph-overhead workload underjax==0.10.0:1089.38 us/call936.28 us/callChecklist
Validation:
tests/nnxunderjax==0.10.0:1686 passed, 10 skippedtests/nnxunderjax==0.10.2:1686 passed, 10 skippedjax==0.10.0:239 passed, 9 skippedis_array_ref(AbstractRef)preserves previous behavior.