Handle captures in nnx.scan#5515
Open
samanklesaria wants to merge 2 commits into
Open
Conversation
samanklesaria
force-pushed
the
handle-captures-scan
branch
2 times, most recently
from
a1dd22e to
760826a
Compare
samanklesaria
force-pushed
the
handle-captures-scan
branch
5 times, most recently
from
494cf0d to
e6c5179
Compare
samanklesaria
force-pushed
the
handle-captures-scan
branch
from
e6c5179 to
4aaf86c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows nnx.scan to transform closures that mutate their closed over values. This PR depends on #5490 and should only be merged after it. This PR incorporate's that PR's changes, because there isn't a way to set the original PR as the base branch in github.