fix(attention): validate dropout_rate range and require dropout_rng w…#5510
Open
Vitaliy-Pikalo wants to merge 1 commit into
Open
fix(attention): validate dropout_rate range and require dropout_rng w…#5510Vitaliy-Pikalo wants to merge 1 commit into
Vitaliy-Pikalo wants to merge 1 commit into
Conversation
…hen needed In `dot_product_attention_weights`, a negative or NaN `dropout_rate` silently passes the `dropout_rate > 0.0` guard, causing dropout to be silently skipped without regularizing — the user gets no error and no dropout. Additionally, when `dropout_rate > 0.0` and `deterministic=False` but `dropout_rng=None`, the error comes from deep inside `jax.random.bernoulli` as "unexpected PRNG key type NoneType" rather than a clear message. Fix: add two early checks at the top of the function body: 1. `ValueError` if `dropout_rate` is not in `[0, 1)` 2. `ValueError` if dropout will be applied but `dropout_rng is None` Fixes google#5497.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
dot_product_attention_weights, a negative or NaNdropout_ratesilently passes thedropout_rate > 0.0guard, causing dropout to be skipped without any warning or error — the user believes regularization is applied but it isn't.Additionally, when
dropout_rate > 0.0anddeterministic=Falsebutdropout_rng=None, the error surfaces deep insidejax.random.bernoulliasTypeError: unexpected PRNG key type NoneTypeinstead of a helpful message pointing to the missing argument.Fix: add two early validation checks at the top of
dot_product_attention_weights:ValueErrorifdropout_rateis not in[0, 1)ValueErrorif dropout will be applied butdropout_rng is NoneFixes #5497.
Checklist